Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from kserve:master #151

Closed
wants to merge 33 commits into from
Closed

[pull] master from kserve:master #151

wants to merge 33 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 19, 2023 •
edited
Loading

See Commits and Changes for more details.

Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Jooho and others added 9 commits December 8, 2023 14:22
@Jooho @danilopeixoto
@yuzisun @ckadner
feat: CA bundle mount options for storage initializer (#3250)
fed1036 
* Add CA bundle configuration

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Implement CA bundle volume mount

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Update tests

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Add default mount path

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Update defaults

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Update constants

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Use constant

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Implement tests

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Rename volume

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Fix name references

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Update configmap

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* fix unit test for pr-3216

Signed-off-by: jooho <jlee@redhat.com>

* add a logic to mount cabundle secret to storage-initializer container

Signed-off-by: jooho <jlee@redhat.com>

* Correct failed conflict resolve of storage_initializer_injector.go

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Revert changes in go.sum

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Revert changes in zz_generated.deepcopy.go

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Revert changes in openapi_generated.go

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Revert changes in zz_generated.deepcopy.go

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* convert Secret to ConfigMap for cabundle

Signed-off-by: jooho <jlee@redhat.com>

* update some sources to solve reviews

Signed-off-by: jooho <jlee@redhat.com>

* Add 'cabundle_configmap' to 'storage-config' StorageSpec

Signed-off-by: jooho <jlee@redhat.com>

* fix new comments

Signed-off-by: jooho <jlee@redhat.com>

* update to fix review comments

Signed-off-by: jooho <jlee@redhat.com>

---------

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Jooho Lee <jlee@redhat.com>
Co-authored-by: Danilo Peixoto <danilopeixoto@outlook.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Christian Kadner <ckadner@us.ibm.com>
@sivanantha321
Fix tensorflow e2e test fails due to OOM error (#3293)
611c4a0 
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
@sivanantha321 @yuzisun
Update Istio-Dex docs (#3260)
58bf8f9 
* Update Istio-Dex docs

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add docs for auth using service account

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix kfserving name 

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
@terrytangyuan
chore: Upgrade Go to v1.21 (#3296)
2874730 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
fix: Properly handle the creation and closure of success file in Down…
d2e3784 
…loadModel() (#3295)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@andyi2it
Updated ray to 2.8.0 and removed detached flag to avoid deprecation e…
c1c5efe 
…rror in future (#3272)

* Update ray serve version
Update tests to remove detached=false parameter

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Pinned `async-timeout` as direct dependency for python 3.11

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

---------

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@terrytangyuan
fix: Surface errors when writing graphHandler response (#3308)
49fd0da 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@sivanantha321
Fix qpext hangs during shutdown (#3268)
f0a47e0 
* Fix qpext hangs during shutdown

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix e2e qpext image build

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Revert vcs info stamping

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
@terrytangyuan
chore: Upgrade to XGBoost v2.0.2. Fixes #3310 (#3309)
27f13d0 
chore: Upgrade to XGBoost v2.0.2

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@openshift-ci openshift-ci bot requested review from Jooho and Xaenalt December 19, 2023 02:48
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pull[bot]
Once this PR has been reviewed and has the lgtm label, please assign xaenalt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2023

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot added ⤵️ pull merge-conflict Resolve conflicts manually and removed needs-rebase needs-ok-to-test labels Dec 19, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Dec 19, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Dec 20, 2023
@terrytangyuan @Jooho
fix: Check if HPA has the same scaleTargetRef and behavior (#3294)
d32e1e2 
* fix: Check if HPA has the same scaleTargetRef

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update pkg/controller/v1beta1/inferenceservice/reconcilers/hpa/hpa_reconciler.go

Co-authored-by: Jooho Lee <ljhiyh@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* chore: simplify semanticHPAEquals

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* chore: simplify

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Co-authored-by: Jooho Lee <ljhiyh@gmail.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Dec 21, 2023
@pull pull bot removed the needs-rebase label Dec 28, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spolti spolti mentioned this pull request Dec 29, 2023
Closed
9 tasks
@pull pull bot removed the needs-rebase label Dec 29, 2023
@terrytangyuan
build: Switch to use kustomize in kubectl to simplify build process. F…
a549773 
…ixes #3314 (#3315)

* build: Switch to use kustomize in kubectl to simplify build process. Fixes #3314

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update scripts in hack folder

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Address comments

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Revert incorrect change

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

terrytangyuan and others added 3 commits December 29, 2023 21:07
@terrytangyuan
feat: Expose defaults for several batcher handler parameters (#3301)
a97db5f 
* feat: Expose defaults for several batcher handler parameters

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix: add timeout

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Add new params to config/manifests

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Remove timeout

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
fix: Properly close resources and handle errors in agent and storage. F…
29ca8c8 
…ixes #3323 (#3321)

* fix: Properly close resources and handle errors in agent and storage

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* reduce indentation

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* return early

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* return -> break

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Address comments

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* newError -> closeErr

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* newError -> closeErr

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@yuzisun
Add model arguments to API and update BERT inference example (#3332)
312bf9b 
* Update bert tokenizer example

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Generate id for infer request

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix model name in tests

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix model_name argument

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix predictor_protocol

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Generate request id if none 

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Set default None for PredictorConfig

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add comment

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Enable doc with default values

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add back add_help false 

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update protocol choices

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix grpc-v2 choice

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@pull pull bot removed the needs-rebase label Dec 31, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@terrytangyuan
chore: Update generated APIs and check generated manifests (#3335)
99d355e 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@pull pull bot removed the needs-rebase label Dec 31, 2023
@yuzisun
Update python model serving runtime API docstring (#3338)
fff1802 
* Update kserve python runtime API docstring

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Use InferenceError

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Jan 1, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Jan 1, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Jan 2, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spolti
Copy link
Member

spolti commented Jan 3, 2024

replaced by #159
due the conflicts, we can't fix it directly into community/master.

@spolti spolti closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jooho Jooho Awaiting requested review from Jooho

@Xaenalt Xaenalt Awaiting requested review from Xaenalt

Assignees
No one assigned
Labels
⤵️ pull merge-conflict Resolve conflicts manually needs-rebase
Projects
ODH Model Serving Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.